Removed dependency to Minimatch #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@Eneuman thank you for your change :) Can you please remove reference from notice.txt and client.signproj? Again happy to take the change forward on our end if you are busy.
Removed text from noticex.txt
…om/Eneuman/Bridge-To-Kubernetes into feature/remove-minmatch-dependency
@elenavillamil Fixed! |
elenavillamil
approved these changes
Mar 15, 2023
hsubramanianaks
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimatch is a NuGet package for matching text patterns and is being used when deciding if a volume should be downloaded or not.
The nuget package only supports .Net Standard 1.0 and has not been activily maintained since 2016.
When bulding B2K, the following warning occures in the output:
warning NU1603: Minimatch 2.0.0 depends on NETStandard.Library (>= 1.0.0-rc2-23910) but NETStandard.Library 1.0.0-rc2-23910 was not found. An approximate best match of NETStandard.Library 1.5.0-rc2-24027 was resolved.This PR removes the dependency to that package.
I have added the tests I could think of but the B2K documentation isn't clear on what wildcard patterns it supports.
Please have a look and see if I missed any test patterns.