Resolves Warning SYSLIB021 - Derived cryptographic types are obsolete

[Eneuman]

This PR solves the SYSLIB021 - Derived cryptographic types are obsolete warning.
It also introduces tests for the MacAddressHash functionallity.

The RunCommandAndGetOutput function was changed to use the existing _platform.ExecuteAndReturnOutput to align the way the program executes externa processes. The timeout was set to 30 sec to make sure the command have enought time to finish. The process will like finish within a second under normal conditions.

[Eneuman]

It would be great if we could also add a tests for Mono.
I can add it if someone can get the output from the "ifconfig -a" command.

[hsubramanianaks]

@Eneuman Thanks for the changes, requested small changes.

[github-actions]

@Eneuman Thanks for your PR!

My review of this pull request is as follows:

This pull request looks good overall. It resolves the SYSLIB021 warning and introduces tests for the MacAddressHash functionality.

The changes look good. The new tests are comprehensive and cover the MacAddressHash functionality. The changes to FipsCompliantSha.cs and MACInformationProvider.cs look correct and are in line with the changes proposed.

The only suggestion I have is to add a comment to the RunCommandAndGetOutput method in MACInformationProvider.cs to explain why the timeout is set to 30 seconds. This will help other developers understand the purpose of the timeout and why it is set to 30 seconds.

[hsubramanianaks]

ifconfig -a

@Eneuman if you have WSL2 you can run this command ifconfig -a , if not let me know I can share some samples.

[github-actions]

@Eneuman Thanks for your PR!

This pull request looks good overall. It resolves the SYSLIB021 warning and introduces tests for the MacAddressHash functionality. The RunCommandAndGetOutput function was changed to use the existing _platform.ExecuteAndReturnOutput to align the way the program executes external processes. The timeout was set to 30 sec to make sure the command have enough time to finish.

The only suggestion I have is to add more comments to the code to explain the purpose of the changes. This will help other developers understand the code better and make it easier to maintain in the future.

[hsubramanianaks]

It would be great if we could also add a tests for Mono. I can add it if someone can get the output from the "ifconfig -a" command.

here is the sample output for ifconfig -a command (I have edited with dummy values).

        ether e6:0e:ae:14:6c:da  txqueuelen 1000  (Ethernet)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 0  bytes 0 (0.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

dummy0: flags=130<BROADCAST,NOARP>  mtu 1500
        ether 6a:c7:29:b2:dc:9e  txqueuelen 1000  (Ethernet)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 0  bytes 0 (0.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1280
        inet 0.0.0.0  netmask 0.0.0.0  broadcast 0.0.0.0
        inet6 fe80::215:5dff:feb6:b81  prefixlen 64  scopeid 0x20<link>
        ether 00:15:5d:b6:0b:81  txqueuelen 1000  (Ethernet)
        RX packets 640092  bytes 605988996 (605.9 MB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 77211  bytes 5949128 (5.9 MB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet 127.0.0.1  netmask 255.0.0.0
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1000  (Local Loopback)
        RX packets 58608  bytes 361924804 (361.9 MB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 58608  bytes 361924804 (361.9 MB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

sit0: flags=128<NOARP>  mtu 1480
        sit  txqueuelen 1000  (IPv6-in-IPv4)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 0  bytes 0 (0.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

tunl0: flags=128<NOARP>  mtu 1480
        tunnel   txqueuelen 1000  (IPIP Tunnel)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 0  bytes 0 (0.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0 ````

[Eneuman]

@hsubramanianaks I have another suggestion, why dont we just replace this code with .Net native plattform independent code like this?

var firstInterface = NetworkInterface.GetAllNetworkInterfaces().First();
var macAddressInBytes = firstInterface.GetPhysicalAddress().GetAddressBytes();
var hashedMacAddressByteArray = MD5.HashData(macAddressInBytes);
var hashedMacAddress= BitConverter.ToString(hashedMacAddressByteArray).Replace("-", string.Empty).ToLowerInvariant();

I switched to MD5 because it's the fastest algorithm, and we are not doing encryption here ;)

[hsubramanianaks]

@hsubramanianaks I have another suggestion, why dont we just replace this code with .Net native plattform independent code like this?

var firstInterface = NetworkInterface.GetAllNetworkInterfaces().First();
var macAddressInBytes = firstInterface.GetPhysicalAddress().GetAddressBytes();
var hashedMacAddressByteArray = MD5.HashData(macAddressInBytes);
var hashedMacAddress= BitConverter.ToString(hashedMacAddressByteArray).Replace("-", string.Empty).ToLowerInvariant();

I switched to MD5 because it's the fastest algorithm, and we are not doing encryption here ;)

yes if it make sense to do in this PR please go ahead.

[Eneuman]

@hsubramanianaks I'll make a seperate PR for this :) This PR can just solve the warning.

[Tatsinnit]

☕️🙏 LGTM - Hopefully we got this all tested et. al. from internal channels. thanks heaps @hsubramanianaks and @Eneuman 🎊

[hsubramanianaks]

testing team approved these changes.