Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to support different auth providers with kubectl proxy #258

Merged
merged 15 commits into from
Jun 5, 2023

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Apr 26, 2023

This PR fixes the following issue

@github-actions
Copy link

@hsubramanianaks Thanks for your PR!

My in-depth review of this pull request is as follows:

This pull request looks to be making changes to support different authentication providers with kubectl proxy. The changes look to be adding a new environment variable, KUBECTL_PROXY, to the EnvironmentVariables.cs file, as well as adding a new property, KubectlProxy, to the IEnvironmentVariables.cs file. Additionally, the K8sClientFactory.cs file is being updated to check for the KUBECTL_PROXY environment variable and use it if it is present.

Overall, the changes look to be valid and should work as intended. However, I would suggest adding a comment to the K8sClientFactory.cs file to explain why the environment variable is being checked and used. Additionally, I would suggest adding a comment to the EnvironmentVariables.cs file to explain what the KUBECTL_PROXY environment variable is used for. This will help future developers understand the purpose of the changes.

@github-actions
Copy link

@hsubramanianaks Thanks for your PR!

My in-depth review of this pull request is as follows:

This pull request looks to be making changes to support different authentication providers with kubectl proxy. The changes look to be adding a new environment variable, KUBECTL_PROXY, to the EnvironmentVariables class, and then using this variable to create a KubernetesClientConfiguration object in the K8sClientFactory class.

The changes look to be valid and should work as intended. However, I would suggest adding a comment to the EnvironmentVariables class to explain what the KUBECTL_PROXY variable is for, and also adding a comment to the K8sClientFactory class to explain why the KUBECTL_PROXY variable is being used. This will help other developers understand the purpose of the changes and make it easier to maintain the code in the future.

Overall, this pull request looks to be making valid changes to support different authentication providers with kubectl proxy. I suggest adding comments to the code to explain the purpose of the changes.

@hsubramanianaks hsubramanianaks marked this pull request as ready for review April 28, 2023 16:05
@cxznmhdcxz
Copy link
Member

Test passed on all 3 platforms in Dev.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊❤️☕️

@hsubramanianaks hsubramanianaks merged commit 406c317 into Azure:main Jun 5, 2023
@hsubramanianaks hsubramanianaks deleted the proxy-feature branch June 5, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants