-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to support different auth providers with kubectl proxy #258
Conversation
@hsubramanianaks Thanks for your PR! My in-depth review of this pull request is as follows: This pull request looks to be making changes to support different authentication providers with kubectl proxy. The changes look to be adding a new environment variable, Overall, the changes look to be valid and should work as intended. However, I would suggest adding a comment to the |
@hsubramanianaks Thanks for your PR! My in-depth review of this pull request is as follows: This pull request looks to be making changes to support different authentication providers with kubectl proxy. The changes look to be adding a new environment variable, KUBECTL_PROXY, to the EnvironmentVariables class, and then using this variable to create a KubernetesClientConfiguration object in the K8sClientFactory class. The changes look to be valid and should work as intended. However, I would suggest adding a comment to the EnvironmentVariables class to explain what the KUBECTL_PROXY variable is for, and also adding a comment to the K8sClientFactory class to explain why the KUBECTL_PROXY variable is being used. This will help other developers understand the purpose of the changes and make it easier to maintain the code in the future. Overall, this pull request looks to be making valid changes to support different authentication providers with kubectl proxy. I suggest adding comments to the code to explain the purpose of the changes. |
src/library/Client/ServiceClients/Handlers/ServiceClientCredentialsHttpHandler.cs
Show resolved
Hide resolved
Test passed on all 3 platforms in Dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊❤️☕️
This PR fixes the following issue