Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named ports fix for headless services #278

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Jun 5, 2023

This PR is to support env variables for named ports for headless services. Named port were not set correctly due to previous PR which caused the named port not printing in right format , now it prints ex: HOST_NAME_SERVICE_NAME_SERVICE_PORT_NAMED_PORT_NAME
This will be helpful for users who rely on env variables especially for services using grpc.

@hsubramanianaks hsubramanianaks changed the title named ports env vars without port number named ports fix for headless services Jun 6, 2023
@hsubramanianaks hsubramanianaks marked this pull request as ready for review June 7, 2023 15:04
@cxznmhdcxz
Copy link
Member

Passed on all 3 platforms.

Copy link

@peterbom peterbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe in the future we could build some static Create methods for PortPair to ensure they're initialized in explicit valid ways, but for now I think it's good to just get the fix in.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊🎊

@Tatsinnit Tatsinnit merged commit e95236d into Azure:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants