-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
named ports fix for headless services #278
named ports fix for headless services #278
Conversation
Passed on all 3 platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe in the future we could build some static Create
methods for PortPair
to ensure they're initialized in explicit valid ways, but for now I think it's good to just get the fix in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊🎊
This PR is to support env variables for named ports for headless services. Named port were not set correctly due to previous PR which caused the named port not printing in right format , now it prints ex: HOST_NAME_SERVICE_NAME_SERVICE_PORT_NAMED_PORT_NAME
This will be helpful for users who rely on env variables especially for services using grpc.