Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft Defender for Cloud plan for Containers #876

Merged
merged 9 commits into from
Jan 28, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Dec 11, 2021

Overview/Summary

As described in issue #874, Microsoft Defender for Cloud has released a new plan to all clouds (Public, Gov, China) for Containers that replaces the plans for Kubernetes & Container Registries.

This has now gone GA as per the announcement here: https://docs.microsoft.com/azure/defender-for-cloud/release-notes#microsoft-defender-for-containers-plan-released-for-general-availability-ga.

This PR fixes/adds/changes/removes

  1. Updates Deploy-ASCDF-Config initiative to use the new plan and policy and removed the Kubernetes & Container Registry plan/policies from the initiative, as shown in the below table:
Policy Definition Display Name Policy Definition ID Note
[Deprecated]: Configure Azure Defender for container registries to be enabled d3d1e68e-49d4-4b56-acff-93cef644b432 REMOVED - Old ACR policy
[Deprecated]: Configure Azure Defender for Kubernetes to be enabled 133047bf-1369-41e3-a3be-74a11ed1395a REMOVED - Old AKS Policy
Configure Microsoft Defender for Containers to be enabled c9ddb292-b203-4738-aead-18e2716e858f ADDED - New grouped containers policy for the new plan
  1. Update all references of "Azure Defender" in portal experiences to "Microsoft Defender for Cloud"

Breaking Changes

None. However, customers should review the guidance here around the plan changes and what it means for existing subscriptions and new subscriptions: https://docs.microsoft.com/azure/defender-for-cloud/release-notes#microsoft-defender-for-containers-plan-released-for-general-availability-ga

Testing Evidence

Public (Commercial)

URL to test yourself: https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.neting.cc%2Fjtracey93%2FEnterprise-Scale%2Ffix-874-mdfc-containers%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.neting.cc%2Fjtracey93%2FEnterprise-Scale%2Ffix-874-mdfc-containers%2FeslzArm%2Feslz-portal.json

image

image

image

image

image

image

China (Mooncake)

Tested here by @faister #876 (comment)

Gov (Fairfax)

Tested by @rspott (thanks 👍)
MicrosoftTeams-image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 added enhancement New feature or request do not merge policy engineering engineering work labels Dec 11, 2021
@jtracey93 jtracey93 requested review from a team as code owners December 11, 2021 23:31
@jtracey93
Copy link
Collaborator Author

@faister Could you perform the testing here for China (Mooncake)? I have updated the guidance and all the code so should just need deploying and testing 👍 Can all be found in my fork/branch here: https://github.com/jtracey93/Enterprise-Scale/tree/fix-874-mdfc-containers

Let me know 👍

Copy link

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@faister
Copy link
Contributor

faister commented Dec 13, 2021

@faister Could you perform the testing here for China (Mooncake)? I have updated the guidance and all the code so should just need deploying and testing 👍 Can all be found in my fork/branch here: https://github.com/jtracey93/Enterprise-Scale/tree/fix-874-mdfc-containers

Let me know 👍

@jtracey93 Sounds good, will try to get some testing done before we speak mid-week. Trying to finish off the other task I told you about.

@jtracey93
Copy link
Collaborator Author

@faister

        Fai Lai
        FTE Could you perform the testing here for China (Mooncake)? I have updated the guidance and all the code so should just need deploying and testing 👍 Can all be found in my fork/branch here: https://github.com/jtracey93/Enterprise-Scale/tree/fix-874-mdfc-containers

Let me know 👍

@jtracey93 Jack Tracey FTE Sounds good, will try to get some testing done before we speak mid-week. Trying to finish off the other task I told you about.

Thanks @faister, this should also fit into that other piece of work nicely 👍 If you can test before mid-week (just need the definitions and assignments tested really, confirming the new built-in definition c9ddb292-b203-4738-aead-18e2716e858f does indeed exist in China (Mooncake) before we merge this PR 👍

@faister
Copy link
Contributor

faister commented Dec 15, 2021

@faister

        Fai Lai
        FTE
        Fai Lai
        FTE Could you perform the testing here for China (Mooncake)? I have updated the guidance and all the code so should just need deploying and testing 👍 Can all be found in my fork/branch here: https://github.com/jtracey93/Enterprise-Scale/tree/fix-874-mdfc-containers

Let me know 👍

@jtracey93

        Jack Tracey
        FTE Jack Tracey FTE Sounds good, will try to get some testing done before we speak mid-week. Trying to finish off the other task I told you about.

Thanks @faister Fai Lai FTE, this should also fit into that other piece of work nicely 👍 If you can test before mid-week (just need the definitions and assignments tested really, confirming the new built-in definition c9ddb292-b203-4738-aead-18e2716e858f does indeed exist in China (Mooncake) before we merge this PR 👍

@jtracey93 All good! The new built-in definition c9ddb292-b203-4738-aead-18e2716e858f exists in Mooncake.
Testing evidence:
Built-in definition for MSD for Containers
image

Policy template deployment succeeded
image

Policy set definition
image

Policy assignment
image

@jtracey93 jtracey93 requested review from amanjeetsingh and a team and removed request for amanjeetsingh January 6, 2022 19:43
@jtracey93
Copy link
Collaborator Author

@Azure/enterprisescale-vteam @Azure/customer-architecture-team - This is now ready for review/approval as testing in all 3 clouds has been completed and attached as evidence above 👍👍

matt-FFFFFF
matt-FFFFFF previously approved these changes Jan 10, 2022
Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good work @jtracey93

@jtracey93 jtracey93 removed the request for review from a team January 28, 2022 10:23
@jtracey93 jtracey93 requested review from matt-FFFFFF and removed request for a team and amanjeetsingh January 28, 2022 10:23
Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering engineering work enhancement New feature or request policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft Defender for Cloud Changes - Container security features to be grouped under Defender for Containers
4 participants