-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Changed to updated API and also added new feature properties #1490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please regenerate all related readme files after changing the templates leveraging the utility in utilities\tools\Set-ModuleReadMe.ps1
### Parameter Usage: `<ParameterPlaceholder>` | ||
|
||
// TODO: Fill in Parameter usage | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either add parameter usage if needed or remove this placeholder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you kindly double check? I still see the old code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I can see the correct code in my branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can. Just update you main to latest & merge it into you branch:
git checkout main
git pull
git checkout 'users/prsaha/apifixrsv#1388'
git merge main
@@ -1,18 +1,19 @@ | |||
# RecoveryServicesProtectionContainer `[Microsoft.RecoveryServices/vaults/protectionContainers]` | |||
# RecoveryServices Vaults ProtectionContainers `[Microsoft.RecoveryServices/vaults/protectionContainers]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# RecoveryServices Vaults ProtectionContainers `[Microsoft.RecoveryServices/vaults/protectionContainers]` | |
# Recovery Services Vaults Protection Containers `[Microsoft.RecoveryServices/vaults/protectionContainers]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you kindly double check? I still see the old code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I can see the correct code in my branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment
This module deploys RecoveryServices Vaults ProtectionContainers. | ||
// TODO: Replace Resource and fill in description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module deploys RecoveryServices Vaults ProtectionContainers. | |
// TODO: Replace Resource and fill in description | |
This module deploys a recovery services vault protection container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -239,6 +239,7 @@ module rsv_backupConfig 'backupConfig/deploy.bicep' = if (!empty(backupConfig)) | |||
storageTypeState: contains(backupConfig, 'storageTypeState') ? backupConfig.storageTypeState : 'Locked' | |||
isSoftDeleteFeatureStateEditable: contains(backupConfig, 'isSoftDeleteFeatureStateEditable') ? backupConfig.isSoftDeleteFeatureStateEditable : true | |||
enableDefaultTelemetry: enableChildTelemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line as it has been correctly replaced below
enableDefaultTelemetry: enableChildTelemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -195,7 +195,9 @@ module rsv_backupStorageConfiguration 'backupStorageConfig/deploy.bicep' = if (! | |||
recoveryVaultName: rsv.name | |||
storageModelType: backupStorageConfig.storageModelType | |||
crossRegionRestoreFlag: backupStorageConfig.crossRegionRestoreFlag | |||
enableDefaultTelemetry: enableReferencedModulesTelemetry | |||
enableDefaultTelemetry: enableChildTelemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace any occurrence of enableChildTelemetry
with enableReferencedModulesTelemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…e/ResourceModules into users/prsaha/apifixrsv#1388
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is off, the PR now shows 618 file updates. Probably due to a pull from main. Please double check.
@@ -1,46 +0,0 @@ | |||
# Recovery Service Vault Protection Container Protected Item `[Microsoft.RecoveryServices/vaults/protectionContainers/protectedItems]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for the subsequent PR #1572 - why are these files deleted?
Description
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist