Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes] Added missing closing bracket to Bicep deployment example, removed unsued VM module parameter & regenerated documentation #1556

Merged
merged 4 commits into from
Jun 21, 2022
Merged

[Fixes] Added missing closing bracket to Bicep deployment example, removed unsued VM module parameter & regenerated documentation #1556

merged 4 commits into from
Jun 21, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Added missing closing bracket to Bicep deployment example,
  • Removed unsued VM module parameter enableDefaultTelemetry
  • Regenerated documentation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jun 19, 2022
@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] modules category: modules labels Jun 19, 2022
@AlexanderSehr AlexanderSehr linked an issue Jun 19, 2022 that may be closed by this pull request
[Bug Report]: The Set-ModuleReadMe script is missing a closing bracket for the Bicep deployment examples #1555
Closed
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) June 19, 2022 22:13
@AlexanderSehr AlexanderSehr mentioned this pull request Jun 21, 2022
Closed
15 tasks
eriqua
eriqua approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit cac99d1 into main Jun 21, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1555_setModuleReadme branch June 21, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: The Set-ModuleReadMe script is missing a closing bracket for the Bicep deployment examples
2 participants
@AlexanderSehr @eriqua