Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Servicebus: Added Customer-Managed-Key & additional resource type handling for removal #1586

Merged
merged 15 commits into from
Jul 9, 2022
Merged

[Modules] Servicebus: Added Customer-Managed-Key & additional resource type handling for removal #1586

merged 15 commits into from
Jul 9, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jun 24, 2022 •
edited
Loading

Description

  • Added CMK capabilities
  • Added additional encrption parameter (#double-encryption)
  • Added removal case handling for resources that cannot be removed as is

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ServiceBus: Namespaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jun 24, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 24, 2022
@AlexanderSehr AlexanderSehr linked an issue Jun 24, 2022 that may be closed by this pull request
Set default values to a secure value - Service Bus Namespaces #792
Closed
@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

Unit Test Results

    1 files      1 suites   1m 11s ⏱️
373 tests 366 ✔️ 7 💤 0 ❌
374 runs  367 ✔️ 7 💤 0 ❌

Results for commit 45feb2c.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) June 24, 2022 13:12
@AlexanderSehr AlexanderSehr changed the title [Modules] Servicebus: Added Customer-Managed-Key [Modules] Servicebus: Added Customer-Managed-Key & additional resource type handling for removal Jun 24, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft June 24, 2022 22:11
@AlexanderSehr AlexanderSehr marked this pull request as draft June 24, 2022 22:11
auto-merge was automatically disabled June 24, 2022 22:11

Pull request was converted to draft

auto-merge was automatically disabled June 24, 2022 22:11

Pull request was converted to draft

@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 24, 2022 22:15
@AlexanderSehr AlexanderSehr marked this pull request as draft June 27, 2022 15:50
@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 27, 2022 17:28
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner June 30, 2022 06:06
AlexanderSehr and others added 2 commits July 8, 2022 10:45
@AlexanderSehr
Merged latest main
8d62ba5
@AlexanderSehr @eriqua
Update modules/Microsoft.ServiceBus/namespaces/deploy.bicep
9ab6a73 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 8, 2022 19:18
@AlexanderSehr AlexanderSehr requested a review from eriqua July 8, 2022 19:18
eriqua
eriqua approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 2373c29 into main Jul 9, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/792_sbCMK branch July 9, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default values to a secure value - Service Bus Namespaces
2 participants
@AlexanderSehr @eriqua