Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Overhauled Disk-Encryption Key handling #1591

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Optimized implementation by making the key version an optional parameter

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: DiskEncryptionSets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jun 25, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 25, 2022
@github-actions
Copy link

github-actions bot commented Jun 25, 2022

Unit Test Results

45 tests   - 71   44 ✔️  - 67   13s ⏱️ -11s
  1 suites ±  0     1 💤  -   4 
  1 files   ±  0     0 ±  0 

Results for commit cde175d. ± Comparison against base commit a0de6ee.

This pull request removes 116 and adds 45 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories/integrationRuntime] used resource type [factories/integrationRuntimes] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories/managedVirtualNetwork] used resource type [factories/managedVirtualNetworks] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories] used resource type [factories/integrationRuntimes] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories] used resource type [factories/managedVirtualNetworks] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories] used resource type [factories] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DataFactory/factories] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories/integrationRuntime] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories/integrationRuntime] All parameters in parameters files exist in template file (deploy.json)
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [diskEncryptionSets] should use one of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] Location output should be returned for resources that use it
…
This pull request removes 5 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories/integrationRuntime] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories/integrationRuntime] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories/managedVirtualNetwork] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories/managedVirtualNetwork] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories/managedVirtualNetwork] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) June 25, 2022 13:07
@AlexanderSehr AlexanderSehr merged commit 0b2ee59 into main Jun 27, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/diskEncrOptimization branch June 27, 2022 09:56
@AlexanderSehr AlexanderSehr changed the title Updated implementation [Modules] Overhauled Disk-Encryption Key handling Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants