Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] AKS: Updated secure defaults #1593

Merged
merged 8 commits into from
Jun 28, 2022
Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jun 25, 2022

Description

  • Updated security reommendations
  • Added disk encryption set parameter
  • Added DiskEncryptionSet to dependency pipeline

Note: I excluded most policies of the attach issue as they'd require deployments onto the cluster. I guess we won't do that.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ContainerService: ManagedClusters
.Platform: Dependencies

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr marked this pull request as draft June 25, 2022 15:16
@AlexanderSehr AlexanderSehr linked an issue Jun 25, 2022 that may be closed by this pull request
18 tasks
@github-actions
Copy link

github-actions bot commented Jun 25, 2022

Unit Test Results

  1 files    1 suites   22s ⏱️
85 tests 85 ✔️ 0 💤 0
86 runs  86 ✔️ 0 💤 0

Results for commit 22d3b71.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 25, 2022 16:20
@AlexanderSehr AlexanderSehr self-assigned this Jun 25, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 25, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft June 27, 2022 15:50
@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 27, 2022 17:28
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) June 27, 2022 17:29
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner June 28, 2022 20:25
@AlexanderSehr AlexanderSehr merged commit c47009b into main Jun 28, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/785_aksSec branch June 28, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default values to a secure value - Azure Kubernetes Services
2 participants