Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] MongoDB: Removed throughput if database is deployed serverless #1571 #1594

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jun 25, 2022

Description

Based on PR #1571 by @itpropro

  • Replaced thoughput parameter with null, if the database capabilities contain EnableServerless.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DocumentDB: DatabaseAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

…ess (#1571)

* fix(mongodb):  Removed throughput if database is deployed serverless

* fix(mongodb):  Added thoughput ternary to collections
@github-actions
Copy link

Unit Test Results

    1 files  ±    0      1 suites  ±0   39s ⏱️ +25s
196 tests +152  194 ✔️ +152  2 💤 +1  0  - 1 
198 runs  +154  196 ✔️ +154  2 💤 +1  0  - 1 

Results for commit cbbffbb. ± Comparison against base commit f05f0aa.

This pull request removes 44 and adds 196 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Insights/components] used resource type [components] should use one of the recent API version(s). Currently using [2020-02-02]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Insights/components] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Location output should be returned for resources that use it
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/mongodbDatabases/collections] used resource type [databaseAccounts/mongodbDatabases/collections] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/mongodbDatabases] used resource type [databaseAccounts/mongodbDatabases/collections] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/mongodbDatabases] used resource type [databaseAccounts/mongodbDatabases] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers] used resource type [databaseAccounts/sqlDatabases/containers] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/sqlDatabases] used resource type [databaseAccounts/sqlDatabases/containers] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/sqlDatabases] used resource type [databaseAccounts/sqlDatabases] should use one of the recent API version(s). Currently using [2021-06-15]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts] used resource type [databaseAccounts/mongodbDatabases/collections] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts] used resource type [databaseAccounts/mongodbDatabases] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts] used resource type [databaseAccounts/sqlDatabases/containers] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts] used resource type [databaseAccounts/sqlDatabases] should use one of the recent API version(s). Currently using [2021-06-15]
…
This pull request removes 1 skipped test and adds 2 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DocumentDB/databaseAccounts/mongodbDatabases/collections] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) June 25, 2022 18:30
@AlexanderSehr AlexanderSehr self-assigned this Jun 25, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 25, 2022
@AlexanderSehr AlexanderSehr merged commit d69070b into main Jun 27, 2022
@AlexanderSehr AlexanderSehr deleted the users/itpropro/fixMongo branch June 27, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants