Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Fix roleAssignments naming and missing rename #1596

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

MariusStorhaug
Copy link
Contributor

Description

  • 100 renames of _rbac -> _roleAssignments
  • 1 rename of file nested_rbac.bicep -> nested_roleAssignments.bicep
  • 1 doc update covering the above

Pipeline references

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug merged commit 0c28ad3 into main Jun 25, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/fixmissingrbac branch June 25, 2022 21:42
@MariusStorhaug MariusStorhaug linked an issue Jun 25, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug self-assigned this Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Fix RBAC module naming to align with namechange
2 participants