[Modules] Added Web PubSub module #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(webpubsub): Added Web PubSub module * feat(webpubsub): Updated folders, added tests, updated readme * feat(webpubsub): Added nested rbac * fix: Applied suggestions from code review Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Integrated multiple review feedback * feat(webpubsub): Added json based test parameters * ci(webpubsub): Added devops and github workflow definitions * fix(webpubsub): Updated default sku Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Updated pipeline variables Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Updated pipeline variables Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Updated pipeline variables Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Deleted .test folder as requested Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
added
enhancement
eriqua
reviewed
Jul 10, 2022
modules/Microsoft.SignalRService/webPubSub/.test/full.parameters.json
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Jul 11, 2022
eriqua
reviewed
Jul 11, 2022
eriqua
reviewed
Jul 11, 2022
eriqua
reviewed
Jul 11, 2022
modules/Microsoft.SignalRService/webPubSub/.bicep/nested_rbac.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Jul 11, 2022
eriqua
reviewed
Jul 11, 2022
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
eriqua
reviewed
Jul 12, 2022
modules/Microsoft.SignalRService/webPubSub/.test/min.parameters.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a module and docs for Web PubSub implementing the following general features:
cc: @itpropro
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist