-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Environment] Enabled CI environment to handle DeploymentTest (bicep) files for new self-contained dependency approach #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
added
[cat] pipelines
category: pipelines
[cat] modules
category: modules
[cat] testing
category: testing
[cat] github
category: GitHub
[cat] azure devops
category: Azure DevOps
labels
Jun 29, 2022
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…Azure/ResourceModules into users/alsehr/1577_RenameFolder2
Ensured that key vault is removed before resource group to ensure purge
Added KeyVault purge for purge protected key vaults
MariusStorhaug
suggested changes
Aug 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and suggestions.
.azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml
Outdated
Show resolved
Hide resolved
.azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml
Outdated
Show resolved
Hide resolved
.azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml
Outdated
Show resolved
Hide resolved
modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep
Outdated
Show resolved
Hide resolved
modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep
Outdated
Show resolved
Hide resolved
modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep
Outdated
Show resolved
Hide resolved
modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep
Outdated
Show resolved
Hide resolved
modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep
Outdated
Show resolved
Hide resolved
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
MariusStorhaug
suggested changes
Aug 29, 2022
MariusStorhaug
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[cat] azure devops
category: Azure DevOps
[cat] github
category: GitHub
[cat] modules
category: modules
[cat] pipelines
category: pipelines
[cat] testing
category: testing
[prio] high
importance of the issue: high priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing 'Self-contained' module dependency deployment for variant 5 #329
Tasks
Open questions
GitHub
Azure DevOps
Pipeline references
Type of Change
Please delete options that are not relevant.