Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI environment] Static validation: move global Pester tests to utilities #1647

Merged
merged 80 commits into from
Jul 14, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jul 7, 2022

Description

  • Moving global Pester tests to utilities/pipeline folder, where all scripts used by the pipelines are
  • Getting rid of hardcoded values, leveraging global variables for the global test file path
  • Optimizing code to further align static validation GH action with ADO pipeline template
  • Updating pipelines to
    • [GH+ADO] Remove Pester test from trigger (not needed in the new location)
    • [GH] Added global variables retrieval to static validation job
  • Updating Wiki

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

GH ADO
DesktopVirtualization: HostPools Build Status
KeyVault: Vaults Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua requested a review from a team as a code owner July 7, 2022 12:05
@eriqua eriqua added enhancement New feature or request [cat] pipelines category: pipelines [cat] testing category: testing labels Jul 7, 2022
@eriqua eriqua linked an issue Jul 7, 2022 that may be closed by this pull request
AlexanderSehr
AlexanderSehr previously approved these changes Jul 14, 2022
@eriqua eriqua merged commit 25c7662 into main Jul 14, 2022
@eriqua eriqua deleted the users/erikag/move-global-tests branch July 14, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] pipelines category: pipelines [cat] testing category: testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Move global tests from modules to utilities folder
3 participants