[Modules] Multi additions to staticSites #1662

AlexanderSehr · 2022-07-12T08:32:53Z

Description

Based on PR by @itpropro #1655

Added the following to staticSites

config (app config and function app config)
customDomains with different validations depending on apex or not
linkedBackends with the 2022-03-01 API to add custom function apps. The userDefinedFunctions endpoint should not be used and is currently broken.

Changes were verified, pester and deployment tested with the respective PowerShell functions. Readme and parameter files have been updated.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Update to documentation

* feat(staticsites): Added linkedBackends to staticSites extension * feat(staticsites): Added tests, readme, linkedBackends * docs(staticsites): Removed parameter placeholder * Update modules/Microsoft.Web/staticSites/config/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update modules/Microsoft.Web/staticSites/config/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update modules/Microsoft.Web/staticSites/customDomains/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update modules/Microsoft.Web/staticSites/linkedBackends/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(staticsites): Integrated PR feedback Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

…/ResourceModules into users/itpropro/staticSites

github-actions · 2022-07-12T08:41:20Z

Unit Test Results

    1 files ±    0     1 suites ±0 1m 17s ⏱️ +56s
165 tests +143 161 ✔️ +140 4 💤 +3 0 ❌ ±0
172 runs +150 167 ✔️ +146 5 💤 +4 0 ❌ ±0

Results for commit 372fd69. ± Comparison against base commit b1101a2.

This pull request removes 22 and adds 165 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/connections] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/connections] folder should contain one or more *parameters.json files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [.test] folder
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [readme.md] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [version.json] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should have a GitHub workflow
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should have an Azure DevOps pipeline
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Parameter file tests.Deployment test file tests.[Microsoft.Network/connections] Bicep test deployment files should invoke test like [module testDeployment '../.*deploy.bicep' = {]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Parameter file tests.Deployment test file tests.[Microsoft.Network/connections] Bicep test deployment name should contain [-test-]
…

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites/config] used resource type [staticSites/config] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites/customDomains] used resource type [staticSites/customDomains] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites/linkedBackends] used resource type [staticSites/linkedBackends] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [staticSites/config] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [staticSites/customDomains] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [staticSites/linkedBackends] should use one of the recent API version(s). Currently using [2022-03-01]
…

This pull request removes 1 skipped test and adds 4 skipped tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/connections] *parameters.json files in the .test folder should be valid json

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/staticSites/config] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/staticSites/customDomains] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/staticSites/linkedBackends] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Web/staticSites] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

modules/Microsoft.Web/staticSites/.test/min.parameters.json

modules/Microsoft.Web/staticSites/.test/parameters.json

modules/Microsoft.Web/staticSites/config/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

modules/Microsoft.Web/staticSites/config/readme.md

itpropro · 2022-09-24T20:33:09Z

@eriqua and @MrMCake can we finally close this PR? The pipeline is failing because of the word "id" is not in uppercase in the linked backends readme, maybe someone can do a quick fix here. Besides that, there is nothing left and I would really like to consume the changes from this module 😅

AlexanderSehr · 2022-09-27T16:44:08Z

Hey @itpropro, I'll take care of it once #1898 is in to make it as easy for me as possible resolving conflicts. Should happen in the next couple days.

eriqua · 2022-09-27T19:09:21Z

Hey @itpropro, I'll take care of it once #1898 is in to make it as easy for me as possible resolving conflicts. Should happen in the next couple days.

@MrMCake, @itpropro PR #1898 is approved and ready to be merged.

AlexanderSehr · 2022-09-27T19:35:14Z

Merged and retesting

modules/Microsoft.Web/staticSites/linkedBackends/deploy.bicep

modules/Microsoft.Web/staticSites/customDomains/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

eriqua

🆗

AlexanderSehr and others added 2 commits July 12, 2022 10:30

First commit

2ff601c

AlexanderSehr requested a review from a team as a code owner July 12, 2022 08:32

AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jul 12, 2022

github-actions bot assigned AlexanderSehr Jul 12, 2022

AlexanderSehr added 3 commits July 12, 2022 10:34

Merge branch 'main' into users/itpropro/staticSites

80d675c

Merge branch 'users/itpropro/staticSites' of https://github.com/Azure…

0c03a45

…/ResourceModules into users/itpropro/staticSites

Update to latest

5d3133b

AlexanderSehr and others added 6 commits July 12, 2022 10:47

Updated docs

d42262e

Updated telemetry & docs

d55c93b

Minor fix

4689ff9

Regenerated main readme

c3639d8

Another try

e8332fa

Updated files on linux

4f3b7b8

AlexanderSehr marked this pull request as draft July 12, 2022 15:45

AlexanderSehr added 3 commits July 12, 2022 21:07

Removed custom domain test as it is not operational

7b74e78

Updated docs

0645038

Updated test

d7fc4ff

AlexanderSehr marked this pull request as ready for review July 12, 2022 20:28

Merged latest main

75a055c

AlexanderSehr enabled auto-merge (squash) July 15, 2022 17:17

Merged latest main

9556d97

eriqua reviewed Jul 22, 2022

View reviewed changes

modules/Microsoft.Web/staticSites/.test/min.parameters.json Outdated Show resolved Hide resolved

eriqua reviewed Jul 22, 2022

View reviewed changes

modules/Microsoft.Web/staticSites/.test/parameters.json Outdated Show resolved Hide resolved

eriqua reviewed Jul 22, 2022

View reviewed changes

modules/Microsoft.Web/staticSites/config/deploy.bicep Outdated Show resolved Hide resolved

eriqua reviewed Jul 22, 2022

View reviewed changes

modules/Microsoft.Web/staticSites/config/deploy.bicep Outdated Show resolved Hide resolved

eriqua reviewed Jul 22, 2022

View reviewed changes

modules/Microsoft.Web/staticSites/config/deploy.bicep Outdated Show resolved Hide resolved

Update modules/Microsoft.Web/staticSites/config/deploy.bicep

e2886a0

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

AlexanderSehr requested a review from eriqua July 23, 2022 20:14

eriqua reviewed Jul 24, 2022

View reviewed changes

modules/Microsoft.Web/staticSites/config/readme.md Show resolved Hide resolved

eriqua mentioned this pull request Aug 1, 2022

[Feature Request]: Modules API version update criteria #1735

Open

AlexanderSehr added 3 commits August 17, 2022 10:30

Update to latest

976bd48

Merge branch 'main' into users/itpropro/staticSites

d13fbca

Updated ReadMe

41cc52f

AlexanderSehr added 2 commits September 27, 2022 21:20

Resolved conflict

ba5b202

Updated test

caa3e86

Updated readme

372fd69