Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] NIC: Updated subnetID to subnetResourceId for consistency #1684

Merged
merged 2 commits into from
Jul 18, 2022
Merged

[Modules] NIC: Updated subnetID to subnetResourceId for consistency #1684

merged 2 commits into from
Jul 18, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jul 17, 2022 •
edited
Loading

Description

  • Updated subnetID to subnetResourceId for consistency

Follow-up to #1677

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachines
Network: NetworkInterfaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 17, 2022 16:37
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jul 17, 2022
@github-actions
Copy link

github-actions bot commented Jul 17, 2022 •
edited
Loading

Unit Test Results

  1 files  ±0    1 suites  ±0   45s ⏱️ -3s
81 tests ±0  80 ✔️ +1  1 💤 ±0  0 ❌  - 1 
86 runs  ±0  85 ✔️ +1  1 💤 ±0  0 ❌  - 1 

Results for commit 7be30bd. ± Comparison against base commit 6f10dd1.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 17, 2022 16:40
@AlexanderSehr AlexanderSehr linked an issue Jul 17, 2022 that may be closed by this pull request
[Bug Report]: Cannot deploy Virtual Machine with Static IP Address #1676
Closed
eriqua
eriqua approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 5a2e2de into main Jul 18, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/nicPropertyName branch July 18, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Cannot deploy Virtual Machine with Static IP Address
2 participants
@AlexanderSehr @eriqua