Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Environment] Added test case for parameter description #1687

Merged
merged 4 commits into from
Jul 21, 2022
Merged

[CI Environment] Added test case for parameter description #1687

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51d4e67
Added test case for parameter description
AlexanderSehr Jul 17, 2022
7b40e15
Update to latest
AlexanderSehr Jul 17, 2022
4380c17
Update utilities/pipelines/staticValidation/module.tests.ps1
AlexanderSehr Jul 21, 2022
2df5658
Update utilities/pipelines/staticValidation/module.tests.ps1
AlexanderSehr Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions utilities/pipelines/staticValidation/module.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,22 @@ Describe 'Deployment template tests' -Tag Template {
$missingParameters.Count | Should -Be 0 -Because ('no required parameters in the template file should be missing in the parameter file. Found missing items: [{0}]' -f ($missingParameters -join ', '))
}
}

It '[<moduleFolderName>] All non-required parameters in template file should not have description that start with "Required."' -TestCases $deploymentFolderTestCases {
param (
[hashtable[]] $testFileTestCases,
[hashtable] $templateContent
)

foreach ($parameterFileTestCase in $testFileTestCases) {
$templateFile_RequiredParametersNames = $parameterFileTestCase.templateFile_RequiredParametersNames
$templateFile_AllParameterNames = $parameterFileTestCase.templateFile_AllParameterNames
$nonRequiredParameterNames = $templateFile_AllParameterNames | Where-Object { $_ -notin $templateFile_RequiredParametersNames }

$incorrectParameters = $nonRequiredParameterNames | Where-Object { ($templateContent.parameters[$_].defaultValue) -and ($templateContent.parameters[$_].metadata.description -like 'Required. *') }
$incorrectParameters.Count | Should -Be 0 -Because ('all non-required parameters in the template file should not have a description that starts with "Required.". Found incorrect items: [{0}]' -f ($incorrectParameters -join ', '))
}
}
}

Context 'Parameter file token tests' {
Expand Down