Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Configure privateDnsZoneGroups on app config #1689

Merged
merged 14 commits into from
Jul 18, 2022
Merged

[Modules] Configure privateDnsZoneGroups on app config #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c61ee6c
enable p dns group
eriqua Jul 17, 2022
3b2ba3a
change resource name
eriqua Jul 17, 2022
6692863
readme
eriqua Jul 17, 2022
a731a49
remove private dns group
eriqua Jul 17, 2022
e8bc614
remove pe
eriqua Jul 17, 2022
d1b9901
change public network access condition
eriqua Jul 17, 2022
10e2b3d
public network access enabled
eriqua Jul 17, 2022
f5dd52e
public network access removed
eriqua Jul 17, 2022
528ae2b
public network access enabled
eriqua Jul 17, 2022
c2ed287
depends on commented
eriqua Jul 17, 2022
0d92151
test separated pe
eriqua Jul 18, 2022
6738b59
remove child
eriqua Jul 18, 2022
ff672df
back to test dns zone
eriqua Jul 18, 2022
e423763
cleanup
eriqua Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/Microsoft.AppConfiguration/configurationStores/.test/min.parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"contentVersion": "1.0.0.0",
"parameters": {
"name": {
"value": "<<namePrefix>>-az-appcs-min-001"
"value": "<<namePrefix>>-az-appc-min-001"
}
}
}
9 changes: 7 additions & 2 deletions modules/Microsoft.AppConfiguration/configurationStores/.test/parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"contentVersion": "1.0.0.0",
"parameters": {
"name": {
"value": "<<namePrefix>>-az-appcs-x-001"
"value": "<<namePrefix>>-az-appc-x-001"
},
"lock": {
"value": "CanNotDelete"
Expand Down Expand Up @@ -72,7 +72,12 @@
"value": [
{
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints",
"service": "configurationStores"
"service": "configurationStores",
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/privateDnsZones/privatelink.azconfig.io"
]
}
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions modules/Microsoft.AppConfiguration/configurationStores/deploy.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ resource configurationStore 'Microsoft.AppConfiguration/configurationStores@2021
}

module configurationStore_keyValues 'keyValues/deploy.bicep' = [for (keyValue, index) in keyValues: {
name: '${uniqueString(deployment().name, location)}-appConfig-KeyValues-${index}'
name: '${uniqueString(deployment().name, location)}-AppConfig-KeyValues-${index}'
params: {
appConfigurationName: configurationStore.name
name: keyValue.name
Expand Down Expand Up @@ -207,7 +207,7 @@ module configurationStore_roleAssignments '.bicep/nested_roleAssignments.bicep'
}]

module configurationStore_privateEndpoints '../../Microsoft.Network/privateEndpoints/deploy.bicep' = [for (privateEndpoint, index) in privateEndpoints: {
name: '${uniqueString(deployment().name, location)}-configurationStore-PrivateEndpoint-${index}'
name: '${uniqueString(deployment().name, location)}-AppConfig-PrivateEndpoint-${index}'
params: {
groupIds: [
privateEndpoint.service
Expand Down
18 changes: 14 additions & 4 deletions modules/Microsoft.AppConfiguration/configurationStores/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ The following module usage examples are retrieved from the content of the files
module configurationStores './Microsoft.AppConfiguration/configurationStores/deploy.bicep' = {
name: '${uniqueString(deployment().name)}-configurationStores'
params: {
name: '<<namePrefix>>-az-appcs-min-001'
name: '<<namePrefix>>-az-appc-min-001'
}
}
```
Expand All @@ -310,7 +310,7 @@ module configurationStores './Microsoft.AppConfiguration/configurationStores/dep
"contentVersion": "1.0.0.0",
"parameters": {
"name": {
"value": "<<namePrefix>>-az-appcs-min-001"
"value": "<<namePrefix>>-az-appc-min-001"
}
}
}
Expand All @@ -330,7 +330,7 @@ module configurationStores './Microsoft.AppConfiguration/configurationStores/dep
name: '${uniqueString(deployment().name)}-configurationStores'
params: {
// Required parameters
name: '<<namePrefix>>-az-appcs-x-001'
name: '<<namePrefix>>-az-appc-x-001'
// Non-required parameters
createMode: 'Default'
diagnosticEventHubAuthorizationRuleId: '/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.EventHub/namespaces/adp-<<namePrefix>>-az-evhns-x-001/AuthorizationRules/RootManageSharedAccessKey'
Expand Down Expand Up @@ -358,6 +358,11 @@ module configurationStores './Microsoft.AppConfiguration/configurationStores/dep
lock: 'CanNotDelete'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/privateDnsZones/privatelink.azconfig.io'
]
}
service: 'configurationStores'
subnetResourceId: '/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints'
}
Expand Down Expand Up @@ -391,7 +396,7 @@ module configurationStores './Microsoft.AppConfiguration/configurationStores/dep
"parameters": {
// Required parameters
"name": {
"value": "<<namePrefix>>-az-appcs-x-001"
"value": "<<namePrefix>>-az-appc-x-001"
},
// Non-required parameters
"createMode": {
Expand Down Expand Up @@ -441,6 +446,11 @@ module configurationStores './Microsoft.AppConfiguration/configurationStores/dep
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/privateDnsZones/privatelink.azconfig.io"
]
},
"service": "configurationStores",
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints"
}
Expand Down
2 changes: 1 addition & 1 deletion modules/Microsoft.AppConfiguration/configurationStores/version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "0.2"
"version": "0.3"
}