Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] ApplicationGateway: Updated descriptions of security relevant parameters #1699

Merged
merged 1 commit into from
Jul 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/Microsoft.Network/applicationGateways/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ param enableFips bool = false
@description('Optional. Whether HTTP2 is enabled on the application gateway resource.')
param enableHttp2 bool = false

@description('Optional. The resource ID of an associated firewall policy.')
@description('Optional. The resource ID of an associated firewall policy. Should be configured for security reasons.')
param firewallPolicyId string = ''

@description('Optional. Frontend IP addresses of the application gateway resource.')
Expand Down Expand Up @@ -163,7 +163,7 @@ param trustedRootCertificates array = []
@description('Optional. URL path map of the application gateway resource.')
param urlPathMaps array = []

@description('Optional. Application gateway web application firewall configuration.')
@description('Optional. Application gateway web application firewall configuration. Should be configured for security reasons.')
param webApplicationFirewallConfiguration object = {}

@description('Optional. A list of availability zones denoting where the resource needs to come from.')
Expand Down
4 changes: 2 additions & 2 deletions modules/Microsoft.Network/applicationGateways/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ This module deploys Network ApplicationGateways.
| `enableHttp2` | bool | `False` | | Whether HTTP2 is enabled on the application gateway resource. |
| `enableRequestBuffering` | bool | `False` | | Enable request buffering. |
| `enableResponseBuffering` | bool | `False` | | Enable response buffering. |
| `firewallPolicyId` | string | `''` | | The resource ID of an associated firewall policy. |
| `firewallPolicyId` | string | `''` | | The resource ID of an associated firewall policy. Should be configured for security reasons. |
| `frontendIPConfigurations` | array | `[]` | | Frontend IP addresses of the application gateway resource. |
| `frontendPorts` | array | `[]` | | Frontend ports of the application gateway resource. |
| `gatewayIPConfigurations` | array | `[]` | | Subnets of the application gateway resource. |
Expand All @@ -74,7 +74,7 @@ This module deploys Network ApplicationGateways.
| `trustedRootCertificates` | array | `[]` | | Trusted Root certificates of the application gateway resource. |
| `urlPathMaps` | array | `[]` | | URL path map of the application gateway resource. |
| `userAssignedIdentities` | object | `{object}` | | The ID(s) to assign to the resource. |
| `webApplicationFirewallConfiguration` | object | `{object}` | | Application gateway web application firewall configuration. |
| `webApplicationFirewallConfiguration` | object | `{object}` | | Application gateway web application firewall configuration. Should be configured for security reasons. |
| `zones` | array | `[]` | | A list of availability zones denoting where the resource needs to come from. |


Expand Down