Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Uplifted ADF module to support managed Private endpoints #1721

Merged
merged 7 commits into from
Aug 3, 2022

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Jul 29, 2022

Closes #1720

Description

  • Added support for a new child module for managed private endpoints for ADF
  • Updated the pester test that inspects a private endpoint resource type to exclude managed private endpoints. The reason is that we are searching for the word 'privateEndpoints' using a like statement, which can conflict with 'managedPrivateEndpoints', thus marking it as the same for API versions.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DataFactory: Factories

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Jul 29, 2022
@ahmadabdalla ahmadabdalla added this to the Release 0.7 milestone Jul 29, 2022
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner July 29, 2022 05:49
@ahmadabdalla ahmadabdalla self-assigned this Jul 29, 2022
@eriqua eriqua changed the title Uplifted ADF module to support managed Private endpoints [Modules] Uplifted ADF module to support managed Private endpoints Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Unit Test Results

    1 files      1 suites   30s ⏱️
154 tests 147 ✔️ 7 💤 0
155 runs  148 ✔️ 7 💤 0

Results for commit 6cc5455.

@eriqua eriqua removed this from the Release 0.7 milestone Aug 3, 2022
@ahmadabdalla ahmadabdalla merged commit ec2becb into main Aug 3, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/adf_updates branch August 3, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Azure Data Factory Module to support Managed Private Endpoints
3 participants