-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Updated & aligned role assignment implementation #1765
Conversation
Unit Test Results 1 files ± 0 1 suites ±0 11s ⏱️ -46s Results for commit b7507dd. ± Comparison against base commit 5042c3d. This pull request removes 83 and adds 42 tests. Note that renamed tests count towards both.
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Hey @MrMCake . I ran the dep. pipeline against the branch, and I got an error related to role assignments: VERBOSE: 00:19:25 - Checking deployment status in 5 seconds
VERBOSE: 00:19:41 - Checking deployment status in 5 seconds
VERBOSE: 00:19:57 - Checking deployment status in 5 seconds
VERBOSE: Deployment output: {}
Exception: /home/runner/work/_temp/ab8a18ad-ec9c-4967-ba4a-57a0aa022e6c.ps1:55
Line |
55 | throw $res.exception
| ~~~~~~~~~~~~~~~~~~~~
| 00:20:11 - The deployment
| 'StoreVhdToStorage-20220810T2308074108Z' failed with error(s).
| Showing 2 out of 2 error(s). Status Message: The template
| output 'resourceId' is not valid: Unable to evaluate template
| language function 'subscriptionResourceId': function requires
| exactly one multi-segmented argument which must be resource
| type including resource provider namespace. Current function
| arguments
| '/subscriptions/***,Microsoft.Authorization/roleAssignments,07cbc5be-c3b1-521c-8663-404ee6c60de7'. Please see https://aka.ms/arm-template-expressions/#subscriptionresourceid for usage details.. (Code:DeploymentOutputEvaluationFailed) Status Message: Unable to evaluate template outputs: 'resourceId'. Please see error details and deployment operations. Please see https://aka.ms/arm-debug for usage details. (Code: DeploymentOutputEvaluationFailed) - The template output 'resourceId' is not valid: Unable to evaluate template language function 'subscriptionResourceId': function requires exactly one multi-segmented argument which must be resource type including resource provider namespace. Current function arguments '/subscriptions/***,Microsoft.Authorization/roleAssignments,07cbc5be-c3b1-521c-8663-404ee6c60de7'. Please see https://aka.ms/arm-template-expressions/#subscriptionresourceid for usage details.. (Code:DeploymentOutputEvaluationFailed) CorrelationId: c1b62108-fba7-4dbc-ad2f-75a5b97c2fa7 Not sure if it is related to this change, but wanted to call this out. Can we look into it EDIT: So I looked at the 'dependencies' pipeline history, and seems to be some work @eriqua which can be related to the error above. As I also see this problem happening when I am testing for the PR i need to merge. Do you think its best we wait for that to be resolved before we merge this change? EDIT2: Upon investigation: The issue happens here in the 'constructs\StoreVhdToStorage\deploy.bicep'.. We are passing the module roleAssignment '../../../../../modules/Microsoft.Authorization/roleAssignments/subscription/deploy.bicep' = {
name: '${uniqueString(deployment().name)}-roleAssignment'
params: {
roleDefinitionIdOrName: 'Contributor'
principalId: 'userMsi.outputs.principalId'
subscriptionId: subscription().id
}
} We should be passing in |
Description
Pipeline references
Type of Change
Please delete options that are not relevant.