Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] VMSS enabledAcceleratedNetworking fix #1777

Merged
merged 214 commits into from
Aug 11, 2022

Conversation

lsnoddy
Copy link
Member

@lsnoddy lsnoddy commented Aug 11, 2022

Description

Fixed bug in enabling AcceleratedNetworking on VMSS

  • Changed code to check for "enabledAcceleratedNetworking" property existence on the indexed array element instead of the outer array
  • Fixed the same issue for the "networkSecurityGroup" property
  • Changed "enabledAcceleratedNetworking" default status from null to true to match default behavior in the portal
  • Updated windows and linux paramter files to a new VM sku compatible with Accelerated Networking; used the same sku as VMs (Standard_B12ms)
  • Updated the readme

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachineScaleSets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@lsnoddy lsnoddy added bug Something isn't working [cat] modules category: modules labels Aug 11, 2022
@lsnoddy lsnoddy requested a review from a team as a code owner August 11, 2022 13:49
@lsnoddy lsnoddy self-assigned this Aug 11, 2022
@lsnoddy lsnoddy merged commit 2fdd979 into Azure:main Aug 11, 2022
@lsnoddy lsnoddy deleted the users/lsnoddy/vmss branch August 11, 2022 16:17
@eriqua eriqua changed the title Users/lsnoddy/vmss [Fixes] VMSS enabledAcceleratedNetworking fix Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: VMSS networkInterfaceConfiguration can't configure enableAcceleratedNetworking and NSG
2 participants