Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Update automationAccounts API Version & Include disableLocalAuth #1790

Conversation

ChrisSidebotham
Copy link
Contributor

Description

Updated microsoft.Automation/automationAccounts to the current GA API Version and included feature disableLocalAuth which is required when using built-in Azure Policy.

Pipeline failed on parameters.json deployment only, this has also been the same on the main branch prior to this change. Other test complete successfully using a default value for disableLocalAuth:true

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Automation: AutomationAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner August 17, 2022 11:47
@ChrisSidebotham ChrisSidebotham linked an issue Aug 17, 2022 that may be closed by this pull request
@ChrisSidebotham ChrisSidebotham added the [cat] modules category: modules label Aug 17, 2022
@AlexanderSehr AlexanderSehr changed the title Update automationAccounts API Version & Include disableLocalAuth [Modules] Update automationAccounts API Version & Include disableLocalAuth Aug 17, 2022
@ahmadabdalla
Copy link
Contributor

@ChrisSidebotham . I am going to submit a PR to remediate the issue of the automation account deploying first. I've created an issue for it here #1792

@ahmadabdalla
Copy link
Contributor

@ChrisSidebotham can you please pull the latest main branch and revalidate the deployment? The issue on automation account has been fixed.

…users/csidebotham/1715-feature-request-update-api-version-and-disable-local-auth
@github-actions
Copy link

Unit Test Results

    1 files      1 suites   1m 48s ⏱️
279 tests 273 ✔️ 6 💤 0
281 runs  275 ✔️ 6 💤 0

Results for commit 162f537.

@ChrisSidebotham
Copy link
Contributor Author

@ahmadabdalla - Branch is passing now

@ChrisSidebotham ChrisSidebotham merged commit cf69d6a into main Aug 19, 2022
@ChrisSidebotham ChrisSidebotham deleted the users/csidebotham/1715-feature-request-update-api-version-and-disable-local-auth branch August 19, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update API version and disable local auth.
3 participants