Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Default value for IpConfiguration name #1806

Merged
merged 8 commits into from
Aug 28, 2022
Merged

[Modules] Default value for IpConfiguration name #1806

merged 8 commits into from
Aug 28, 2022

Conversation

milescattini
Copy link
Contributor

@milescattini milescattini commented Aug 27, 2022

Description

Azure/bicep-registry-modules#2373

Added a default value for the Ip configuration of network interfaces. Now if no value is provided for the IP configuration, the IP configuration is named 'ipconfig-{currentIndex}'.

image

Whilst there are other IP configuration name values across the modules (e.g., Azure Firewall), only the Virtual Machine is updated. The rationale being the name for an AZ Firewall IP configuration is more significant than that within a network interface.

Pipeline references

Pipeline
Network: NetworkInterfaces

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@milescattini milescattini marked this pull request as ready for review August 27, 2022 13:34
@milescattini milescattini requested a review from a team as a code owner August 27, 2022 13:34
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 27, 2022
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :) Just some minor suggestions.

modules/Microsoft.Network/networkInterfaces/deploy.bicep Outdated Show resolved Hide resolved
modules/Microsoft.Network/networkInterfaces/readme.md Outdated Show resolved Hide resolved
@milescattini
Copy link
Contributor Author

@ahmadabdalla ready for round 2 when you are.

Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

@milescattini
Copy link
Contributor Author

Thanks @ahmadabdalla! I do not have access to merge. I'll leave for you whenever it suits

@ahmadabdalla ahmadabdalla merged commit e509a65 into Azure:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants