-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Default value for IpConfiguration name #1806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution :) Just some minor suggestions.
@ahmadabdalla ready for round 2 when you are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution :)
Thanks @ahmadabdalla! I do not have access to merge. I'll leave for you whenever it suits |
Description
Azure/bicep-registry-modules#2373
Added a default value for the Ip configuration of network interfaces. Now if no value is provided for the IP configuration, the IP configuration is named 'ipconfig-{currentIndex}'.
Whilst there are other IP configuration name values across the modules (e.g., Azure Firewall), only the Virtual Machine is updated. The rationale being the name for an AZ Firewall IP configuration is more significant than that within a network interface.
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist