Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Configure privateDnsZoneGroups on web sites #2005

Merged
merged 2 commits into from
Sep 9, 2022
Merged

[Modules] Configure privateDnsZoneGroups on web sites #2005

merged 2 commits into from
Sep 9, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Sep 9, 2022 •
edited
Loading

Description

Add privateDnsZoneGroups to tests using private endpoints

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Web: Sites

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua linked an issue Sep 9, 2022 that may be closed by this pull request
Configure privateDnsZoneGroups on web sites (sites - privatelink.azurewebsites.net) #2004
Closed
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022 •
edited
Loading

Unit Test Results

    1 files      1 suites   55s ⏱️
131 tests 125 ✔️ 6 💤 0 ❌
134 runs  128 ✔️ 6 💤 0 ❌

Results for commit 1dab20a.

♻️ This comment has been updated with latest results.

@eriqua eriqua marked this pull request as ready for review September 9, 2022 18:13
@eriqua eriqua requested a review from a team as a code owner September 9, 2022 18:13
@eriqua eriqua enabled auto-merge (squash) September 9, 2022 18:13
@eriqua eriqua merged commit 03c0e8e into main Sep 9, 2022
@eriqua eriqua deleted the users/erikag/2004-sites-dns branch September 9, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@eriqua eriqua

Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure privateDnsZoneGroups on web sites (sites - privatelink.azurewebsites.net)
2 participants
@eriqua @ahmadabdalla