Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] [BPR alignment] Remove Microsoft. prefix and rename README.md files - part 1/2 #3165

Merged
merged 65 commits into from
May 10, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented May 4, 2023

Description

Closes #3056
Addresses part of issue 3132 by removing the Microsoft. prefix from the resource provider folder name.

A second PR is expected to cover an update of all readme files through the set-modulereadme script, which should remove the Microsoft. prefix from the module reference in the deployment examples and update the link to child module documentation (due to the readme to README file name update)

This is part 1 of 2 PRs. Fully updated modules are the ones in the DesktopVirtualization, Storage and Authorization (policyAssignments) resource provider. Same goes for the corresponding workflows and pipelines.

Next PR will cover the update of all readme files and all workflows and pipelines. Next PR will also cover updates to constructs.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DesktopVirtualization - HostPools
DesktopVirtualization - Workspaces
Storage - StorageAccounts
Authorization - PolicyAssignments
Storage Build Status
AVD Scaling Plans Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriqua In one wiki file we still have 'Microsoft.' references towards the end of the file

eriqua and others added 5 commits May 9, 2023 11:45
@eriqua
Copy link
Contributor Author

eriqua commented May 9, 2023

@eriqua In one wiki file we still have 'Microsoft.' references towards the end of the file

Just removed a bunch of additional occurrences, please check if that covered

@AlexanderSehr
Copy link
Contributor

@eriqua In one wiki file we still have 'Microsoft.' references towards the end of the file

Just removed a bunch of additional occurrences, please check if that covered

I can still see it.

@eriqua
Copy link
Contributor Author

eriqua commented May 9, 2023

@eriqua In one wiki file we still have 'Microsoft.' references towards the end of the file

Just removed a bunch of additional occurrences, please check if that covered

I can still see it.

@AlexanderSehr should be fixed now

@eriqua eriqua merged commit 0f05a13 into main May 10, 2023
@eriqua eriqua deleted the users/erikag/bpr-folderrename_01 branch May 10, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines [cat] testing category: testing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PBR alignment] [Modules] Align readme.md file naming
2 participants