-
Notifications
You must be signed in to change notification settings - Fork 522
feat: Support existing load balancer backend address pool for agent nodes #1145
feat: Support existing load balancer backend address pool for agent nodes #1145
Conversation
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xuto2 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/azp run pr-e2e |
/needs-rebase |
217c4d1
to
ad0dccf
Compare
@xuto2 FYI I rebased on top of master/force-pushed to this branch, so you'll need to pull down for future dev |
Squash commit message needs to be updated to use semantic message (or if a second commit is pushed the title is enough). /hold |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
two commits will use PR title as squash message so we're good now. /hold cancel |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
=========================================
Coverage ? 74.58%
=========================================
Files ? 131
Lines ? 18425
Branches ? 0
=========================================
Hits ? 13742
Misses ? 3902
Partials ? 781 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sylr nevermind I understand what this does, I have another possible fix for the lack of UDP outbound incoming shortly... |
Congrats on merging your first pull request! 🎉🎉🎉 |
Thanks @jackfrancis @CecileRobertMichon @feiskyer ! |
Reason for Change:
Azure Standard Load Balancer(SLB) introduces some fundamental difference to Azure Basic Load Balancer(BLB). Specifically, vmas/vmss behind Azure SLB don't automatically get internet access like BLB, and it's Azure's recommendation that we "always use outbound rules on a Standard public Load Balancer" (see https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-outbound-connections for details).
To support Azure SLB in AKS, AKS needs to maintain the outbound rules of the SLB (and the load balancer rules as well to workaround upstream issue when using SLB kubernetes/kubernetes#76691). So we need the ability to place AKS engine generated nodes (VMSS+VMAS) into an existing SLB's backend address pool.
Requirements:
Notes: