fix: create role assignment for master VMs

[dennis-benzinger-hybris]

Fixes #2373
Fixes #2367

[mboersma]

Thanks! I changed the PR title to match the first commit, because that's more human-readable and will appear in the release notes.

[mboersma]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jackfrancis]

@dennis-benzinger-hybris I added some quick unit test coverage to the additions in types.go. If you enable contributions from maintainers on this PR I can push that up.

Or, you could add those UT yourself, thanks!

[dennis-benzinger-hybris]

@dennis-benzinger-hybris I added some quick unit test coverage to the additions in types.go. If you enable contributions from maintainers on this PR I can push that up.

Oh, sorry :-). Didn't want to exclude you. I've activated the checkbox now.

[devigned]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dennis-benzinger-hybris]

/azp run pr-e2e

[azure-pipelines]

Commenter does not have sufficient privileges for PR 2583 in repo Azure/aks-engine

[devigned]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jackfrancis]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[codecov]

Codecov Report

Merging #2583 into master will increase coverage by 0.04%.
The diff coverage is 91.22%.

@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
+ Coverage   71.79%   71.83%   +0.04%     
==========================================
  Files         131      131              
  Lines       24787    24844      +57     
==========================================
+ Hits        17795    17847      +52     
- Misses       5966     5970       +4     
- Partials     1026     1027       +1

[dennis-benzinger-hybris]

@jackfrancis, I've added a test for createKubernetesMasterRoleAssignmentForAgentPools which should fix the code coverage. Please start the /azp run pr-e2e once more.

[jackfrancis]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jackfrancis]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dennis-benzinger-hybris]

The latest job seems to have failed because of

Status=429 Code=\"OperationNotAllowed\" Message=\"The server rejected the request because too many requests have been received for this subscription.\"

for some Kubernetes versions.
(from https://dev.azure.com/aks-engine/AKS-Engine/_build/results?buildId=3747&view=logs&j=a48fcffa-d400-5086-fd55-6a393fb8fdb7&t=9d93e863-c26a-5b58-475a-eafe7efc9f3e)

@jackfrancis, could you please investigate this or restart the job?

I don't have access to the Azure subscriptions used in the tests.

[jackfrancis]

@dennis-benzinger-hybris those results are not related to your change.

I've rebased this PR on top of current master to improve E2E test fidelity, and am running a broader set of cluster configuration tests against this branch, including back-compat for upgrade and scale. Hang tight, we're almost there! :)

And thank you again.

[dennis-benzinger-hybris]

@jackfrancis, have you started the pipeline after your push?

[devigned]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jackfrancis]

/lgtm

Thanks again @dennis-benzinger-hybris !

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dennis-benzinger-hybris, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dennis-benzinger-hybris]

@jackfrancis, thanks for merging 👍 . Do you have any idea when there will be a release with this fix?

[jackfrancis]

We will cut a v0.46.1 by tomorrow EOD -8 GMT at the latest.