This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: make master availabilityProfile an optional field for Azure Stack #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjaini
reviewed
Mar 10, 2020
pkg/api/const.go
Outdated
| // DefaultAzureStackAcceleratedNetworking set to false as Azure Stack today doesn't support accelerated networking | ||
| DefaultAzureStackAcceleratedNetworking = false | ||
|
|
||
| DefaultAzureStackAvailabilityProfile = AvailabilitySet |
There was a problem hiding this comment.
nit: Good to add a comment for consistency purpose.
There was a problem hiding this comment.
yes, please add a comment here to the exported const
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
+ Coverage 72.46% 72.46% +<.01%
==========================================
Files 140 140
Lines 25675 25677 +2
==========================================
+ Hits 18606 18608 +2
Misses 5993 5993
Partials 1076 1076 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
PR #2717 made master.availabilityProfile a required field.
Issue Fixed:
#2855