This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: use upstreamartifacts CDN URL for apmz #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
=======================================
Coverage 72.57% 72.57%
=======================================
Files 141 141
Lines 25934 25934
=======================================
Hits 18821 18821
Misses 6014 6014
Partials 1099 1099 |
| @@ -219,7 +219,7 @@ downloadAzureCNI() { | |||
|
|
|||
| ensureAPMZ() { | |||
There was a problem hiding this comment.
@xuto2 would it make sense to also exclude AKS from this install since it isn't using CSE telemetry?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Changes the URL for
apmzto reference the Azure CDN, for consistency and also to facilitate locking down egress rules. (We reference the upstreamartifacts.azureedge.net URL consistently otherwise, so this looks like an oversight.)Issue Fixed:
Requirements:
Notes:
cc: @palma21