feat: Updating Windows VHD build files to support building for multiple OS versions #3847
Conversation
…onal storage account
…e run-packer-windows-call and added succeeded condition checks everywher
…cific vars from a file
…cific vars from a file
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
==========================================
- Coverage 73.20% 72.83% -0.38%
==========================================
Files 148 149 +1
Lines 25428 23171 -2257
==========================================
- Hits 18614 16876 -1738
+ Misses 5679 5178 -501
+ Partials 1135 1117 -18
Continue to review full report at Codecov.
|
marosset
changed the title
|
I decided to not convert the Windows vhd packer file to use the HashiCorp Config Langauge becasue this is a smaller set of changes that accomplishes the same goals. |
| "resource_group_name": "{{user `resource_group_name`}}", | ||
| "capture_container_name": "aksengine-vhds-windows-ws2019", |
There was a problem hiding this comment.
this will change from ws2019 to 2019 by default, is that okay?
There was a problem hiding this comment.
I think it should be ok. This is only used in the paths in the storage account the VHD gets captured into correct?
There was a problem hiding this comment.
yeah should be fine, we get the URI directly from the output so we don't expect it to be in a specific place 👍
|
Let me revert chagnes tot he scale.go file.. not sure how those got picked up... |
|
it's a github beta feature |
|
First time I saw that. Thanks. |
| @@ -40,6 +40,7 @@ jobs: | |||
| -e BUILD_ID=$(Build.BuildId) \ | |||
| -e BUILD_NUMBER=$(Build.BuildNumber) \ | |||
| -e CONTAINER_RUNTIME=$(CONTAINER_RUNTIME) \ | |||
| -e WINDOWS-SERVER-VERSION=2019 \ | |||
There was a problem hiding this comment.
should 2019 be an environment variable so it can be configured on the job?
There was a problem hiding this comment.
Possibly. We still need to have a discussion around what images aks-engine should actually be producing. If we want to produce more than just Windows Server 2019 + Docker I think I would rather just update the pipepline to build all the images as different stages and avoid the need to trigger multiple pipelines.
I'm hoping we can resolve that with a different PR tho.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…le OS versions (Azure#3847) * Updating configure-windows-vhd.ps1 to support multiple Windows OS versions * Updating configured-windows-vhd.ps1 to not use containerd from a personal storage account * Updating windows packer file to take in windows os version specific vars from a file * updating windows build pipeline/packer.mk to pass new vars file to packer * formatting configure-windows-vhd-ps1 * vhd-builder-windows.yaml adding missing WINDOWS_SERVER_VERSION to make run-packer-windows-call and added succeeded condition checks everywher * fixup! updating windows build pipeline/packer.mk to pass new vars file to packer * fixup! Updating windows packer file to take in windows os version specific vars from a file * fixup! Updating windows packer file to take in windows os version specific vars from a file
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: