-
Notifications
You must be signed in to change notification settings - Fork 522
repro: broken system-assigned identity #3861
repro: broken system-assigned identity #3861
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -4,6 +4,7 @@ | |||
"orchestratorProfile": { | |||
"orchestratorType": "Kubernetes", | |||
"kubernetesConfig": { | |||
"useManagedIdentity": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cluster configuration we maintain to run PR E2E tests in fact has the required criteria to demonstrate the bug; we merely need to enable system-assigned identity (enabled above) to reproduce.
Codecov Report
@@ Coverage Diff @@
## master #3861 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 149 149
Lines 23171 23171
=======================================
Hits 16876 16876
Misses 5178 5178
Partials 1117 1117
Continue to review full report at Codecov.
|
@@ -361,10 +361,10 @@ func Build(cfg *config.Config, masterSubnetID string, agentSubnetIDs []string, i | |||
} | |||
} | |||
|
|||
if config.MSIUserAssignedID != "" { | |||
/*if config.MSIUserAssignedID != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this repro, we want to make sure we're using system-assigned ID and not user-assigned ID
Reason for Change:
This PR demonstrates the current state of system-assigned identity in a multiple node pool cluster configuration where more than one pool shares a common VNET.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: