Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

repro: broken system-assigned identity #3861

Closed

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR demonstrates the current state of system-assigned identity in a multiple node pool cluster configuration where more than one pool shares a common VNET.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Sep 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -4,6 +4,7 @@
"orchestratorProfile": {
"orchestratorType": "Kubernetes",
"kubernetesConfig": {
"useManagedIdentity": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cluster configuration we maintain to run PR E2E tests in fact has the required criteria to demonstrate the bug; we merely need to enable system-assigned identity (enabled above) to reproduce.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #3861 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3861   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23171           
=======================================
  Hits        16876    16876           
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a577d...c6dec2c. Read the comment docs.

@acs-bot acs-bot added size/S and removed size/XS labels Sep 24, 2020
@@ -361,10 +361,10 @@ func Build(cfg *config.Config, masterSubnetID string, agentSubnetIDs []string, i
}
}

if config.MSIUserAssignedID != "" {
/*if config.MSIUserAssignedID != "" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this repro, we want to make sure we're using system-assigned ID and not user-assigned ID

@jackfrancis jackfrancis deleted the repro-broken-vnet-user-assigned-id branch September 29, 2020 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants