Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated capture.js (v1) to output errors in case of failure. #1011

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

TimMcCann
Copy link
Contributor

Per Issue 998. #998
Add a catch and check for 200 response code in scripts/capture.js

@ghost
Copy link

ghost commented Oct 31, 2020

CLA assistant check
All CLA requirements met.

@azaslonov azaslonov changed the title updated capture.js (v1) Updated capture.js (v1) Oct 31, 2020
Copy link
Member

@azaslonov azaslonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

scripts/capture.js Outdated Show resolved Hide resolved
Copy link
Member

@azaslonov azaslonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@azaslonov azaslonov changed the title Updated capture.js (v1) Updated capture.js to output errors in case of failure (v1) Oct 31, 2020
@azaslonov azaslonov changed the title Updated capture.js to output errors in case of failure (v1) Updated capture.js (v1) to output errors in case of failure. Oct 31, 2020
@azaslonov azaslonov merged commit dfbf6dc into Azure:master Oct 31, 2020
@ghost
Copy link

ghost commented Jul 9, 2021

@TimMcCann, in recognition of your contributions, we would like to offer you a small token of appreciation. Could you send us the following details to apimportalfeedback@microsoft.com by Sunday, July 18th?

  • Your email address
  • Your GitHub username
  • This pull request number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants