Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed authorization header remove logic #1940

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

malincrist
Copy link
Member

@malincrist malincrist commented Sep 13, 2022

Problem

The Authorization header is not correctly refreshed in test console. Its value is removed when selecting "No auth" and the Http Request is not updated accordingly.

Solution

  1. If the authorization header is added as a separate header for the API and marked as required, it will not be removed when selecting "No auth".
    Its value will be removed and the HTTP Request will be updated accordingly.
    Users cannot remove this header.
    It is marked as required by the text "Value is required" under the input.

  1. If If the authorization header is added as a separate header for the API and not marked as required, it will not be removed when selecting "No auth".
    Its value will be removed and the HTTP Request will be updated accordingly.
    Users can remove this header manually.

  1. If the authorization header is not defined for the API, when a grant type is selected (eg: "implicit"), it will be added in the Headers section, and its value will be populated.
    When "No auth" is selected, the header will be removed and the HTTP Request will be updated accordingly.
    Users can remove this header manually.

The authorization header is always marked as secret: It will always be displayed with its value masked out and with the additional toggle button that provides the possibility to display its actual value.
auth_rename

Closes #1933

@github-actions
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 28 check(s) passed, and 24 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@azaslonov azaslonov merged commit 474d3b8 into master Sep 14, 2022
@azaslonov azaslonov deleted the malincrist/bug/authorization-header branch September 14, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorization header is not correctly refreshed in 'Http request ' section in Operation Details Widget
2 participants