Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing inconsistency between Sample request body select label and aria-label #1962

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Fixing inconsistency between Sample request body select label and aria-label #1962

merged 3 commits into from
Oct 6, 2022

Conversation

jsorohova
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 28 check(s) passed, and 24 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

harunrst
harunrst approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@harunrst harunrst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, loved it!

@jsorohova jsorohova merged commit f2ccec0 into master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malincrist malincrist malincrist approved these changes

@harunrst harunrst harunrst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsorohova @harunrst @malincrist