Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed async and wait for the server listen event before test run #2209

Merged
merged 16 commits into from
Jun 14, 2023

Conversation

f-alizada
Copy link
Collaborator

Remove not needed async and wait for the server listen event before test run

@@ -18,7 +18,7 @@
},
{
"name": "ocp-apim-sas-token",
"value": await Utils.getSharedAccessToken(this.publicId, "accesskey", 1)
"value": Utils.getSharedAccessToken(this.publicId, "accesskey", 1)

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "accesskey" is used as [key](1).
@github-actions
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 28 check(s) passed, and 24 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@f-alizada f-alizada merged commit c3a0eeb into master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants