Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed non-working anchors for definitions, made multiple complex schemas more readable #2389

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

jsorohova
Copy link
Collaborator

Closes: #2326, #2290

Problems:

  1. Definition anchors were not working, all links were redirecting to the top of the page.
  2. When multiple definitions were listed in complex schemas, they were truncated.

Solutions:

  1. Fixed scrolling so it scrolls to the definition.
  2. Listed every definition on the new line so they are not truncated.

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@jsorohova jsorohova merged commit 1f68f15 into master Feb 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell text truncated because there is no wrap when using "oneof"
2 participants