Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default media files to regional storage #2407

Conversation

malincrist
Copy link
Member

Problem

The default media files are stored in a storage account from West US. VNet services can't access these files without whitelisting the endpoint and "Microsoft.Storage.Global".

Solution

Upload the media files to the regional storages that are accessible even for services in VNet and use them from there.
During provisioning, we will replace the download URL with the URL of the service and the path to the image.

Changes in the default.json file:

  • re-named the files to not use GUID but the file name
  • removed downloadUrl from properties
    Screenshot 2024-02-14 151010
  • changed where they are referenced to use the name not the GUID
    Screenshot 2024-02-14 150921

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@malincrist malincrist marked this pull request as ready for review February 15, 2024 15:41
@malincrist malincrist merged commit 4a51397 into master Feb 23, 2024
10 checks passed
@malincrist malincrist deleted the malincrist/feature/move-default-media-files-to-regional-storage branch February 23, 2024 08:04
malincrist added a commit that referenced this pull request Apr 11, 2024
jsorohova pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants