Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: registered apiProducts widget correctly #2411

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

malincrist
Copy link
Member

Problem

The widget API: Products is registered with type apiProducts, but used in the model binder with type api-products. Due to this, the widget will not be recognized, when converting to contract.

Solution

Use the type apiProducts in the model binder as well.

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@malincrist malincrist merged commit 1baf9b4 into master Feb 19, 2024
10 checks passed
@malincrist malincrist deleted the malincrist/bug/api-products-widget-disappears branch February 19, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants