Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser specific iframe sandbox tokens support #2514

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

JMach1
Copy link
Member

@JMach1 JMach1 commented Jun 19, 2024

Remove iframe sandbox tokens which are not supported in Safari to separated string and add based on if the browser supports them. This way we won't break existing customer widgets.

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 27 check(s) passed, and 25 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

src/components/custom-widget/ko/runtime/customWidget.ts Outdated Show resolved Hide resolved
src/constants.ts Show resolved Hide resolved
@JMach1 JMach1 merged commit 0077622 into master Jul 11, 2024
9 checks passed
@JMach1 JMach1 deleted the iframe-support-for-inconsistant-browsers branch July 16, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants