Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes for Site menu item modal #2661

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

jsorohova
Copy link
Collaborator

Included fixes:

  • Correct parent displaying for all item types (it was not working for Media items)
  • Removed the item itself from the list of possible parents
  • Fixed error handling on item type change

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@jsorohova jsorohova merged commit 8e44ec0 into master Aug 21, 2024
9 checks passed
@jsorohova jsorohova deleted the js/site-menu-fixes branch August 30, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants