Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content-Type to uploadBlobs function #990

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

TomBonnerAtTFL
Copy link
Contributor

@TomBonnerAtTFL TomBonnerAtTFL commented Oct 21, 2020

Uses the package mime-types to calculate the file extension from the content-type when it downloads blobs, saves that with the extension, then uses the extension to calculate a content-type to upload with. Fixes #989.

Fixes Azure#989 by adding content-type awareness to the capture/generate functionality.
@ghost
Copy link

ghost commented Oct 21, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@azaslonov azaslonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom, that's a good one! Thanks a lot for your contribution.

@azaslonov azaslonov merged commit 8ba9d71 into Azure:master Oct 21, 2020
@mikebudzynski
Copy link
Contributor

Thanks for your contribution @TomBonnerAtTFL!

TomBonnerAtTFL added a commit to TomBonnerAtTFL/api-management-developer-portal that referenced this pull request Oct 23, 2020
Add Content-Type to `uploadBlobs` function (Azure#990)
@ghost
Copy link

ghost commented Jul 9, 2021

@TomBonnerAtTFL, in recognition of your contributions, we would like to offer you a small token of appreciation. Could you send us the following details to apimportalfeedback@microsoft.com by Sunday, July 18th?

  • Your email address
  • Your GitHub username
  • This pull request number

ygrik pushed a commit that referenced this pull request Apr 1, 2022
ygrik pushed a commit that referenced this pull request Apr 4, 2022
jsorohova pushed a commit that referenced this pull request Apr 14, 2022
maciejtreder pushed a commit that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload/Download scripts don't migrate Content-Type
3 participants