Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allocateLoadBalancerNodePorts option #280

Merged
merged 7 commits into from
Mar 12, 2024
1 change: 1 addition & 0 deletions helm-charts/azure-api-management-gateway/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ their default values.
| `service.type` | Type of Kubernetes service to use to expose to serve traffic | `ClusterIP` |
| `service.annotations` | Annotations to add to the Kubernetes service | `{}` |
| `service.loadBalancer.ip` | Attach a pre-existing static IP to a `LoadBalancer` type service. Learn more in the [Kubernetes docs](https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer). | |
| `service.allocateLoadBalancerNodePorts` | Defines if NodePorts will be automatically allocated for services with type LoadBalancer | `true` |
tomkerkhove marked this conversation as resolved.
Show resolved Hide resolved
| `service.ports.http` | Port for HTTP traffic on service for other pods to talk to | `8080` |
| `service.ports.https` | Port for HTTPs traffic on service for other pods to talk to | `8081` |
| `service.ports.instance.synchronization` | Port used for internal discovery of gateway instances to synchronize across all of them, ie for rate limiting. | `4290` |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,13 @@ metadata:
{{- end }}
spec:
type: {{ .Values.service.type }}
{{- if eq .Values.service.type "LoadBalancer" }}
{{- if (.Values.service.loadBalancer).ip }}
loadBalancerIP: {{ .Values.service.loadBalancer.ip }}
{{- end }}
{{- if eq .Values.service.allocateLoadBalancerNodePorts false }}
tomkerkhove marked this conversation as resolved.
Show resolved Hide resolved
tomkerkhove marked this conversation as resolved.
Show resolved Hide resolved
allocateLoadBalancerNodePorts: false
{{- end }}
{{- end }}
ports:
- port: {{ .Values.service.ports.http }}
Expand Down
1 change: 1 addition & 0 deletions helm-charts/azure-api-management-gateway/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ dapr:

service:
type: ClusterIP
allocateLoadBalancerNodePorts: true
tomkerkhove marked this conversation as resolved.
Show resolved Hide resolved
ports:
http: 8080
https: 8081
Expand Down