Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

don't use default rg in test #354

Merged
merged 4 commits into from
May 11, 2020

Conversation

changlong-liu
Copy link
Member

No description provided.

@changlong-liu changlong-liu requested a review from qiaozha May 9, 2020 09:12
@qiaozha
Copy link
Member

qiaozha commented May 9, 2020

which issue is this PR trying to resolve.
If the list command has two operation listbysubscription and listbyresourcegroup inside it. -g "" will only test the listbysubscription.
Is this what they wanted?

@changlong-liu
Copy link
Member Author

Hi @qiaozha ,
It's for #337.
Yes, this PR add -g "" for those example don't provide any resourcegroup, so that we can explicitly tell that the test is for list-by-subscription.
If we need to test list-by-resource group, we can use the example in which a resourcegroup is provided.

@qiaozha
Copy link
Member

qiaozha commented May 11, 2020

okay, approved.

@changlong-liu changlong-liu merged commit 72f359e into Azure:master May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants