Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

poly in example/test #449

Merged
merged 6 commits into from
Jun 23, 2020
Merged

Conversation

changlong-liu
Copy link
Member

No description provided.

@changlong-liu changlong-liu requested a review from qiaozha June 22, 2020 02:31
@@ -119,7 +119,7 @@ def step__integrationruntimes_put_integrationruntimes_create(test, rg):
# EXAMPLE: /IntegrationRuntimes/put/IntegrationRuntimes_Create
@try_manual
def step__integrationruntimes_put_integrationruntimes_create(test, rg):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dup definition of step__integrationruntimes_put_integrationruntimes_create is because of examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should come from the generated configuration in the before version. corrected here: 26b5d24

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

# EXAMPLE: /Triggers/put/Triggers_Update
@try_manual
def step__triggers_put_triggers_update(test, rg):
test.cmd('az datafactory trigger create '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here the name still is create. it should be update isn't it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also. I think the parameters list should be different from create.

@@ -31,6 +30,8 @@ cli:
- name: /IntegrationRuntimes/post/IntegrationRuntimes_Upgrade
- name: /IntegrationRuntimes/patch/IntegrationRuntimes_Update
- name: /Triggers/put/Triggers_Create
- name: /Triggers/put/Triggers_Create
- name: /Triggers/put/Triggers_Update
- name: /Triggers/put/Triggers_Update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duped with the one you added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the generic create/update problem in test, I'll check it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then you should match the operation CreateOrUpdate#Update

Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks still have some problem in the create or update example match

@qiaozha qiaozha merged commit 549c834 into Azure:master Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants