-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
@@ -119,7 +119,7 @@ def step__integrationruntimes_put_integrationruntimes_create(test, rg): | |||
# EXAMPLE: /IntegrationRuntimes/put/IntegrationRuntimes_Create | |||
@try_manual | |||
def step__integrationruntimes_put_integrationruntimes_create(test, rg): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dup definition of step__integrationruntimes_put_integrationruntimes_create is because of examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should come from the generated configuration in the before version. corrected here: 26b5d24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it.
# EXAMPLE: /Triggers/put/Triggers_Update | ||
@try_manual | ||
def step__triggers_put_triggers_update(test, rg): | ||
test.cmd('az datafactory trigger create ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the name still is create. it should be update isn't it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also. I think the parameters list should be different from create.
@@ -31,6 +30,8 @@ cli: | |||
- name: /IntegrationRuntimes/post/IntegrationRuntimes_Upgrade | |||
- name: /IntegrationRuntimes/patch/IntegrationRuntimes_Update | |||
- name: /Triggers/put/Triggers_Create | |||
- name: /Triggers/put/Triggers_Create | |||
- name: /Triggers/put/Triggers_Update | |||
- name: /Triggers/put/Triggers_Update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this duped with the one you added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the generic create/update problem in test, I'll check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then you should match the operation CreateOrUpdate#Update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks still have some problem in the create or update example match
No description provided.