Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Change on Boarding Doc #461

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Change on Boarding Doc #461

merged 1 commit into from
Jul 14, 2020

Conversation

LianwMS
Copy link
Contributor

@LianwMS LianwMS commented Jun 28, 2020

No description provided.

@@ -1,30 +1,31 @@
# Onboarding process for using Azure Cli Codegen (autorest.az)
# Onboarding Process for Using Azure Cli Code-gen (autorest.az)
Copy link
Member

@RodgeFu RodgeFu Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another file called "onboarding-guide.md" at the same folder. please clear that folder and link to this one. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the other one


In reply to: 449503255 [](ancestors = 449503255)


## Step 2. Quick Validation
If it is your first time to use Azure Cli code-gen, please discuss with the contact person. He/She will:
Copy link
Member

@RodgeFu RodgeFu Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the contact person [](start = 72, length = 18)

please mention a contact person will be assigned to help in Step1. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added


In reply to: 449503755 [](ancestors = 449503755)

Autorest.az has been integrated into swagger PR. It means you can start reviewing your CLI code/command immediately when your swagger PR is filed for your new features/changes, so your new features/changes can have Azure CLI support very soon.

Hopefully, **your CLI is ready to merge/release when your swagger is ready to merge. :shipit: :+1:**
## Step 5. Run Linter and Style
Copy link
Member

@RodgeFu RodgeFu Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run Linter and Style [](start = 11, length = 20)

let's merge this into Step4 to make things look simpler #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


In reply to: 449504555 [](ancestors = 449504555)


## Step 7. Onboarding to azure-cli
Copy link
Member

@RodgeFu RodgeFu Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onboarding to azure-cli [](start = 11, length = 23)

please merge this with Step6 #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved


In reply to: 449504853 [](ancestors = 449504853)

* run azdev style
``` bash
> azdev style {service_name}
```
Copy link
Member

@RodgeFu RodgeFu Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge this with test to make things look simpler.thx #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve


In reply to: 449505426 [](ancestors = 449505426)

@LianwMS LianwMS force-pushed the lianw/onBoardDoc branch 6 times, most recently from 7a60b98 to de6cd3b Compare July 10, 2020 01:42
@LianwMS LianwMS force-pushed the lianw/onBoardDoc branch from de6cd3b to 4b2bdc1 Compare July 14, 2020 03:33
@LianwMS LianwMS merged commit f9a9bc2 into master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants