This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
multiline: respect comment and start space #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changlong-liu
force-pushed
the
20200623-resourcename
branch
from
d00f3ed to
c1121e7
Compare
qiaozha
reviewed
Jul 1, 2020
| @@ -23,7 +23,7 @@ | |||
| examples: | |||
| - name: Factories_ListByResourceGroup | |||
| text: |- | |||
| az datafactory list --resource-group "exampleResourceGroup" | |||
| az datafactory list --resource-group "myResourceGroup2" | |||
There was a problem hiding this comment.
this should be the second resource-group in all example files
There was a problem hiding this comment.
Why? They are exampleResourceGroup in all the examples.
There was a problem hiding this comment.
fixed here: 6ec8b8a
| @@ -32,7 +32,7 @@ | |||
| examples: | |||
| - name: Factories_Get | |||
| text: |- | |||
| az datafactory show --name "exampleFactoryName" --resource-group "exampleResourceGroup" | |||
| az datafactory show --name "exampleFactoryName" --resource-group "myResourceGroup" | |||
There was a problem hiding this comment.
I think what CLI team wanted is for all the resource name change it into myResourceName
There was a problem hiding this comment.
For ezample exampleFactoryName => myFactoryName
There was a problem hiding this comment.
internal resource name are fixed in here: 9bf198e
qiaozha
reviewed
Jul 1, 2020
| @@ -181,8 +181,10 @@ export interface CodeModelAz { | |||
| GetPreparerEntities(): any[]; | |||
| GatherInternalResource(); | |||
| FindExampleWaitById(id: string): string[][]; | |||
| GetExampleItems(example: CommandExample, isTest: boolean, commandParams: any): string[]; | |||
There was a problem hiding this comment.
I am wondering when do we call this GetExampleItems and pass isTest as true?
There was a problem hiding this comment.
qiaozha
approved these changes
Jul 1, 2020
qiaozha
approved these changes
Jul 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #429 #404 #406 #428