This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
try-fix-m4-error #112
Merged
try-fix-m4-error #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lirenhe
reviewed
Feb 5, 2021
| @@ -55,11 +55,11 @@ | |||
| "typescript": "^3.8.3" | |||
| }, | |||
| "dependencies": { | |||
| "@azure-tools/autorest-extension-base": "^3.1.235", | |||
| "@azure-tools/codegen": "^2.5.276", | |||
| "@azure-tools/autorest-extension-base": "3.1.235", | |||
There was a problem hiding this comment.
Though we use the fixed version here, we still need to do the following in the future:
- Regularly update the dependency libraries to catch up with their latest update/bug fixing
- Understand the root cause on how that version upgrade causing the break. We could send feedback to data plane team to avoid that.
There was a problem hiding this comment.
Agreed. But I found two of them has been renamed.
"@azure-tools/autorest-extension-base" => "@autorest/extension-base"
"@azure-tools/codemodel" => "@autorest/codemodel"
and we are not aware any of this changes. It would be nice if they can notice us such kind of change.
lirenhe
approved these changes
Feb 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.