Move splitted operation references to cli-split-operation-splitted-operations #66
Conversation
src/nodeHelper.ts
Outdated
| @@ -219,6 +220,16 @@ export class NodeHelper { | |||
| return NodeHelper.getExtensionsProperty(op, NodeHelper.SPLIT_OPERATION_ORIGINAL_OPERATION, null); | |||
| } | |||
|
|
|||
| public static addSplitOperationSplittedOperations(op: Operation, splittedOp: Operation) { | |||
There was a problem hiding this comment.
this name is confusing, will you be able to understand it 3 month later?
src/helper.ts
Outdated
| @@ -347,6 +347,7 @@ export class Helper { | |||
| (isNullOrUndefined(NodeHelper.getPolyAsResourceParam(vv)) ? '' : `${NEW_LINE}${tab(3)}cli-poly-as-resource-subclass-param: ${NodeHelper.getCliKey(NodeHelper.getPolyAsResourceParam(vv), '<missing-clikey>')}`) + | |||
| (isNullOrUndefined(NodeHelper.getPolyAsResourceOriginalOperation(vv)) ? '' : `${NEW_LINE}${tab(3)}cli-poly-as-resource-original-operation: ${NodeHelper.getCliKey(NodeHelper.getPolyAsResourceOriginalOperation(vv), '<missing-clikey>')}`) + | |||
| (isNullOrUndefined(NodeHelper.getSplitOperationOriginalOperation(vv)) ? '' : `${NEW_LINE}${tab(3)}cli-split-operation-original-operation: ${NodeHelper.getCliKey(NodeHelper.getSplitOperationOriginalOperation(vv), '<missing-clikey>')}`) + | |||
| (NodeHelper.getSplitOperationSplittedOperations(vv, () => []).length === 0 ? '' : `${NEW_LINE}${tab(3)}cli-split-operation-splitted-operations: ${NodeHelper.getSplitOperationSplittedOperations(vv, () => []).map((vvv) => NodeHelper.getCliKey(vvv, '<missing-clikey>')).join(',')}`) + | |||
| `${NEW_LINE}${tab(3)}parameters:${NEW_LINE}`.concat( | |||
| vv.parameters.map(vvv => `${tab(3)}- parameterName: ${generateCliValue(vvv, 4)}${generatePropertyFlattenValue(vvv, 4)}${generatePropertyReadonlyValue(vvv, 4)}${generateDiscriminatorValueForParam(vvv, 4)}${NEW_LINE}` + | |||
| (isNullOrUndefined(NodeHelper.getPolyAsResourceBaseSchema(vvv)) ? '' : `${tab(4)}cli-poly-as-resource-base-schema: ${NodeHelper.getCliKey(NodeHelper.getPolyAsResourceBaseSchema(vvv), '<baseSchemaCliKeyMissing>')}${NEW_LINE}`) + | |||
There was a problem hiding this comment.
this code is getter more and more complex, feel free to refactor it if you want.
There was a problem hiding this comment.
yes, I will do refactor later, thanks
src/nodeHelper.ts
Outdated
| @@ -219,6 +220,16 @@ export class NodeHelper { | |||
| return NodeHelper.getExtensionsProperty(op, NodeHelper.SPLIT_OPERATION_ORIGINAL_OPERATION, null); | |||
| } | |||
|
|
|||
| public static addSplitOperationIntoOperations(op: Operation, splittedOp: Operation) { | |||
There was a problem hiding this comment.
how about make it more generic to have it in NodeHelper, we dont need split concept here, for example, addExtendedOperation(node: Operation, operation: Operation)
There was a problem hiding this comment.
I am worried about generic may cause confusing. Because previously we put these operations in cli-operations, which makes az cannot know these operations come from poly or split. That's why I create an independent property for split.
There was a problem hiding this comment.
Removed reference. Thanks
|
This works from my side now |
|
@qiaozha thanks for confirming. But we decide to delete the reference from original operation to splitted operations. Because we regard it is unnecessary. We can use the |
Put splitted operation references in cli-operations cause confusing. This pr move those references into independent extension property
cli-split-operation-splitted-operations